ci: Don't duplicate report filenames

Define report filenames as variables if they are referenced more than
once to make sneaky typos less likely.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3745>

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 621ecee7bed2b958ae92118a74919bf8b80762b7..f8f29803a97773cb7ce4f2bda14e0d7b671d3b57 100644 (file)
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -82,10 +82,11 @@ check-commit-log:
   stage: pre-review
   variables:
     GIT_DEPTH: "100"
+    JUNIT_REPORT: commit-message-junit-report.xml
   script:
     - if [[ x"$CI_MERGE_REQUEST_TARGET_BRANCH_NAME" != "x" ]] ;
       then
-        ci-fairy check-commits --junit-xml=commit-message-junit-report.xml ;
+        ci-fairy check-commits --junit-xml=$JUNIT_REPORT ;
       else
         echo "Not a merge request" ;
       fi
@@ -94,16 +95,18 @@ check-commit-log:
   artifacts:
     expire_in: 1 week
     reports:
-      junit: commit-message-junit-report.xml
+      junit: $JUNIT_REPORT
 
 check-merge-request:
   extends:
     - .fdo.ci-fairy
   stage: pre-review
+  variables:
+    JUNIT_REPORT: check-merge-request-report.xml
   script:
     - if [[ x"$CI_MERGE_REQUEST_TARGET_BRANCH_NAME" != "x" ]] ;
       then
-        ci-fairy check-merge-request --require-allow-collaboration --junit-xml=check-merge-request-report.xml ;
+        ci-fairy check-merge-request --require-allow-collaboration --junit-xml=$JUNIT_REPORT ;
       else
         echo "Not a merge request" ;
       fi
@@ -112,7 +115,7 @@ check-merge-request:
   artifacts:
     expire_in: 1 week
     reports:
-      junit: check-merge-request-report.xml
+      junit: $JUNIT_REPORT
 
 build-fedora-container:
   extends: